Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Debug: Fix abort in debug mode on unknown entries' #49

Merged
merged 1 commit into from
Jan 15, 2024
Merged

'Debug: Fix abort in debug mode on unknown entries' #49

merged 1 commit into from
Jan 15, 2024
+8 −2

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Jan 12, 2024 •
edited
Loading

When status-report was executed using --debug and --entries=, and one of the entries was not known, it terminated with an error in a debug message (after it had already written the output archive).

Fix this by logging a warning for the unknown option.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f8bafd) 84.90% compared to head (2cc49bc) 84.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   84.90%   84.93%   +0.03%     
==========================================
  Files          15       15              
  Lines        1928     1932       +4     
==========================================
+ Hits         1637     1641       +4     
  Misses        291      291
Flag Coverage Δ
python2.7 83.43% <100.00%> (+0.03%) ⬆️
python3.10.13 83.78% <100.00%> (+0.03%) ⬆️
unittest 83.78% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

Coverage

Pytest Code coverage comment for Python 2.7
FileStmtsMissCoverMissing
xen-bugtool152729780%77–79, 84, 95, 100–101, 410, 486, 491, 511, 517, 540, 602, 620, 637, 686–689, 693–694, 708, 712, 727–728, 734–735, 740, 750, 759, 762–765, 771, 776–778, 781–782, 785–786, 789, 830–832, 967–981, 983–992, 1053, 1061, 1178, 1180, 1184–1185, 1209, 1227, 1230–1232, 1235–1239, 1242–1243, 1247–1249, 1255–1261, 1264–1268, 1270–1286, 1289–1297, 1300–1301, 1303, 1305–1306, 1308–1316, 1319, 1321–1324, 1326, 1328–1329, 1363, 1391, 1406, 1414–1415, 1419–1421, 1423, 1430, 1432–1436, 1438, 1468–1470, 1472–1477, 1480–1484, 1488–1489, 1491, 1508–1509, 1511, 1513–1514, 1516–1518, 1520–1527, 1529–1534, 1538–1539, 1541, 1543, 1545, 1561–1562, 1564, 1566–1568, 1571–1572, 1574, 1576–1578, 1581–1582, 1584, 1586–1589, 1592–1602, 1605–1609, 1618, 1631, 1641, 1645, 1680–1682, 1755, 1790, 1829, 1889, 1932, 1935–1936, 1974, 1981, 1987, 1989–1992, 1995–2005, 2096–2098, 2101–2103, 2115, 2134–2136, 2176–2180, 2192, 2210
integration
   __init__.py00100% 
   conftest.py180100% 
   namespace_container.py35197%85
   test_system_load.py180100% 
   test_xenserver_config.py130100% 
   utils.py61493%18, 31, 66, 104
mocks/xen
   __init__.py00100% 
mocks/xen/lowlevel
   __init__.py00100% 
mocks/xen/lowlevel/xc
   __init__.py50100% 
unit
   __init__.py00100% 
   conftest.py28967%34, 36–40, 42–44
   test_dir_list.py110100% 
   test_fs_funcs.py100100% 
   test_load_plugins.py50100% 
   test_main.py101892%162, 239–241, 243–246
   test_output.py640100% 
   test_process_output.py110100% 
   test_xapidb_filter.py190100% 
TOTAL192631983% 

Tests Skipped Failures Errors Time
19 1 💤 0 ❌ 0 🔥 2.294s ⏱️

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

Coverage

Python3 coverage comment from https://github.com/marketplace/actions/pytest-coverage-comment
FileStmtsMissCoverMissing
__init__.py00100% 
conftest.py320100% 
test_dir_list.py110100% 
test_fs_funcs.py100100% 
test_load_plugins.py50100% 
test_main.py1030100% 
test_output.py640100% 
test_process_output.py110100% 
test_xapidb_filter.py190100% 
xen-bugtool152728981%95, 100–101, 410, 491, 511, 517, 540, 602, 620, 637, 686–689, 693–694, 708, 712, 727–728, 734–735, 740, 750, 759, 771, 776–778, 781–782, 785–786, 789, 830–832, 851, 967–981, 983–992, 1053, 1061, 1178, 1180, 1184–1185, 1209, 1227, 1230–1232, 1235–1239, 1242–1243, 1247–1249, 1255–1261, 1264–1268, 1270–1286, 1289–1297, 1300–1301, 1303, 1305–1306, 1308–1316, 1319, 1321–1324, 1326, 1328–1329, 1363, 1391, 1406, 1414–1415, 1419–1421, 1423, 1430, 1432–1436, 1438, 1468–1470, 1472–1477, 1480–1484, 1488–1489, 1491, 1508–1509, 1511, 1513–1514, 1516–1518, 1520–1527, 1529–1534, 1538–1539, 1541, 1543, 1545, 1561–1562, 1564, 1566–1568, 1571–1572, 1574, 1576–1578, 1581–1582, 1584, 1586–1589, 1592–1602, 1605–1609, 1619, 1631, 1641, 1645, 1680–1682, 1790, 1814, 1829, 1889, 1932, 1935–1936, 1974, 1981, 1987, 1989–1992, 1995–2005, 2096–2098, 2101–2103, 2115, 2134–2136, 2176–2180, 2192, 2210
TOTAL178228983% 

Tests Skipped Failures Errors Time
15 0 💤 0 ❌ 0 🔥 1.014s ⏱️

liulinC
liulinC previously approved these changes Jan 12, 2024
View reviewed changes
@bernhardkaindl bernhardkaindl dismissed liulinC’s stale review January 12, 2024 10:16

The merge-base changed after approval.

@bernhardkaindl bernhardkaindl force-pushed the fix-debug-mode-abort-on-unknown-entries branch from 868c8c7 to 187b328 Compare January 12, 2024 10:16
@bernhardkaindl bernhardkaindl force-pushed the fix-debug-mode-abort-on-unknown-entries branch from 187b328 to 2cc49bc Compare January 12, 2024 10:17
@bernhardkaindl bernhardkaindl added the bug Something isn't working label Jan 15, 2024
@bernhardkaindl bernhardkaindl merged commit 62686a5 into master Jan 15, 2024
6 checks passed
@bernhardkaindl bernhardkaindl deleted the fix-debug-mode-abort-on-unknown-entries branch January 15, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeraldEV GeraldEV GeraldEV approved these changes

@ashwin9390 ashwin9390 ashwin9390 approved these changes

@liulinC liulinC Awaiting requested review from liulinC

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bernhardkaindl @codecov-commenter @ashwin9390 @liulinC @GeraldEV